213 Commits

Author SHA1 Message Date
Evoluseis
f55c819185 SPIGOT-2151: Add support for getting simple bounding box of a block 2018-12-19 10:34:47 +11:00
Parker Hawke
4b843638ea Add BlockData#getAsString(boolean) to hide unspecified states 2018-12-18 11:03:20 +11:00
md_5
aa36c8417b Mappings Update 2018-12-06 10:00:00 +11:00
md_5
ca22de36ab SPIGOT-4469: Age API for EndGateway 2018-11-07 11:15:24 +11:00
md_5
5184216f27 SPIGOT-4447: Clear error for people trying to set an item as a block 2018-10-27 08:21:49 +11:00
md_5
d6b57bd963 SPIGOT-4446: Legacy rotation methods don't work for wall mounted skulls 2018-10-27 08:15:41 +11:00
blablubbabc
4a47be6164 Add ray tracing and bounding box API 2018-10-26 20:00:00 +11:00
md_5
b4230a9a7e Update to Minecraft 1.13.2 2018-10-23 06:00:00 +11:00
blablubbabc
e3d7b2fd96 Add Block#isPassable 2018-10-13 09:49:25 +11:00
md_5
e7ced970d2 Catch plugins setting null Material or BlockData to blocks 2018-10-13 09:43:05 +11:00
md_5
5cffeca21f SPIGOT-4391: Sign editable API 2018-09-24 15:01:10 +10:00
md_5
3eb8af2340 SPIGOT-4348: Use online player for setting skull owner if possible 2018-09-06 20:47:37 +10:00
md_5
908516f102 Fix some formatting in CraftLootable 2018-08-27 18:32:35 +10:00
md_5
c2cbdc5ab4 SPIGOT-4316: Do even less processing when block placement without physics requested 2018-08-27 18:29:28 +10:00
md_5
b3dc236663 SPIGOT-4307: Fix hacky API for banners on shields 2018-08-26 19:18:56 +10:00
Senmori
a677257885 Add additional tests for CraftBlockData 2018-08-26 18:17:55 +10:00
md_5
ce1af0c348 Update to Minecraft 1.13.1 2018-08-26 12:00:00 +10:00
md_5
f41aae401e Remove reflection from CraftBlockData 2018-08-25 08:41:14 +10:00
Senmori
c0df4b82d3 SPIGOT-1936: LootTable API 2018-08-12 18:40:03 +10:00
md_5
cfc67965f3 Add merging and matching of parsed BlockData 2018-08-06 14:40:06 +10:00
md_5
5e3082c7d8 SPIGOT-4230: Improve legacy block types 2018-08-05 10:04:19 +10:00
md_5
69970127c1 SPIGOT-4221: Update surrounding blocks for cancelled break/place 2018-08-03 11:34:26 +10:00
md_5
80c43fc1de SPIGOT-4214: Catch attempts to create BlockData for items 2018-08-02 20:24:56 +10:00
md_5
03c1273b59 SPIGOT-4197: Account for double trapped chests 2018-07-31 09:14:44 +10:00
md_5
4d3ef4821f SPIGOT-4164: Treat new _AIR blocks as air 2018-07-28 08:28:56 +10:00
md_5
2100017016 SPIGOT-4132: Fix missing break in RedstoneWire.setFace 2018-07-24 12:46:21 +10:00
md_5
ca75fead2c SPIGOT-4131: Fix typo affecting setting BlockData 2018-07-24 12:04:34 +10:00
md_5
fbf903a1bc SPIGOT-4120: Store BlockData enum mappings per class 2018-07-24 10:08:34 +10:00
md_5
6a109cf6bc SPIGOT-4124: Fix misplaced PISTON_HEAD 2018-07-24 08:25:13 +10:00
md_5
1a6b4f5392 Update to Minecraft 1.13 2018-07-22 12:00:00 +10:00
md_5
7c0f69e449 CraftBlock.toString shouldn't make legacy call 2018-07-20 16:10:48 +10:00
md_5
66b62a63b5 Fix bad old API call in CraftBlockState 2018-07-20 10:32:17 +10:00
md_5
49ac8a7446 SPIGOT-4074: Fix createBlockData succeeding on garbage 2018-07-20 10:20:15 +10:00
md_5
9c98002856 Fix Block.setType alone being treated as legacy 2018-07-18 16:59:41 +10:00
md_5
3791cf947e SPIGOT-4037: Improve legacy BlockState.setData 2018-07-18 09:53:50 +10:00
md_5
404d6e776e SPIGOT-4036: Handle regular/uncoloured shulker boxes 2018-07-18 09:45:27 +10:00
md_5
322f2f9518 CraftBanner also needs to use wool data 2018-07-16 10:37:56 +10:00
Senmori
cfc30bb382 Add javadocs to new CraftBlockData utility methods. 2018-07-15 16:36:02 +10:00
md_5
421c1728c8 Update to Minecraft 1.13-pre7 2018-07-15 10:00:00 +10:00
md_5
f4ca1805d6 Fix bad usage of setter in previous commit 2018-02-12 10:38:09 +11:00
Senmori
f8411ea1e5 Expand Structure Block API 2018-02-12 10:33:19 +11:00
Senmori
c7656468e4 Expand CreatureSpawner API 2018-01-24 17:19:41 +11:00
md_5
67b763c5a7 Fix Block PistonMoveReaction 2018-01-10 10:47:26 +11:00
blablubbabc
45c83860e1 SPIGOT-3696: Clearing custom name of some blocks does not work 2017-12-17 11:41:56 +11:00
Lukas Hennig
e1f296d115 Fix CraftBanner initialisation. 2017-08-07 17:55:47 +10:00
Lukas Hennig
19507baf8b Improvements to BlockStates
* Actually capture all the data of TileEntities. This is done by creating a copy of the TileEntity. The methods of BlockState which currently directly access the TileEntity reference will modify the data of that TileEntity-snapshot instead.
* With the call to BlockState.update, the captured TileEntity data gets applied to the current TileEntity in the world.
* Methods which trigger block specific actions will use the current TileEntity from the world.
* CraftBlockState does not hand out the wrapped or the snapshot TileEntity directly. Instead, it provides an applyTo method to copy the data to a given TileEntity and a method to directly get a copy of the TileEntity NBT data represented by the BlockState. CraftMetaBlockState was updated to make use of that.
* Added #getSnapshotInventory() to bukkit which allows modifiying the captured inventory snapshots of containers.
* Tried to clarify which methods only work if the BlockState is placed, which methods require the block in the world to still be of the same type (methods which trigger actions), and that .getInventory() directly modifies the inventory of the block in the world if the BlockState is placed and becomes invalid if the block type is changed.

Backwards compatibility

* If the BlockState acts as InventoryHolder, getInventory() will still return the inventory directly backed by the TileEntity in the world (like before), and not the snapshot inventory. This compromise should reduce the potential of these changes to break existing plugins, or craftbukkit's own use of BlockState.
* The snapshot's inventory can be accessed by a new method getSnapshotInventory()
* In case the BlockState is not placed (if it was retrieved from the MetaBlockState of an item), the getInventory() method will however return the snapshot inventory. So that when the BlockState gets applied back to the item, the inventory changes are properly included.
* With the changes to CraftMetaBlockState it is no longer required to call the update method before passing a modified BlockState to the CraftMetaBlockState. For backwards compatibility the update method will simply return true for a non-placed BlockState, without actually doing anything.

Impact on plugins
* Restoring blocks now actually works as expected, properly restoring the TileEntity data, reglardless if the block changed its type in the meantime.
* Plugins are now consistently required to call the update method in order to apply changes to blocks. Though, regarding the Javadoc they should have been required to do so anyways.
* New feature: Plugins can take and modify inventory snapshots.
* Breaking change: If a plugin gets the BlockState of a block in the world, modifies the inventory returned by .getInventory(), and then tries to use the same BlockState to apply the TileEntity data to an ItemStack block meta, the ItemStack will use the snapshot inventory, disregarding the changes made to the inventory returned by .getInventory(). This is the compromise of .getInventory() returning the inventory directly backed by the TileEntity in the world.

Other fixes related to BlockState:
* TileEntityContainer#getLocation() will run into a NPE if the TileEntity is non-placed (ex. when getting the BlockState from a CraftMetaBlockState).
* Beacon.getEntitiesInRange() would previously throw a NPE if called for a non-placed BlockState. It was changed to now require to be placed and use the current TileEntity in the world. If the TileEntity in the world is no longer a beacon, it will return an empty list.
* EndGateway now supports setting and getting the exit location even for non-placed EndGateways (inside BlockStateMeta) by using / returning a location with world being null.
2017-08-05 14:37:19 +10:00
md_5
5195487ec6 Update to Minecraft 1.12-pre2 2017-05-14 12:00:00 +10:00
md_5
e17c3d285b Make CraftJukebox.isPlaying locally consistent 2017-04-16 08:26:51 +10:00
md_5
473febc73a Add correct interfaces for comparator / daylight detector 2017-04-16 08:16:49 +10:00
md_5
ac405c3cd4 Fix some blockstate consistency issues. 2017-04-15 18:01:44 +10:00