181 Commits

Author SHA1 Message Date
md_5
49ac8a7446 SPIGOT-4074: Fix createBlockData succeeding on garbage 2018-07-20 10:20:15 +10:00
md_5
9c98002856 Fix Block.setType alone being treated as legacy 2018-07-18 16:59:41 +10:00
md_5
3791cf947e SPIGOT-4037: Improve legacy BlockState.setData 2018-07-18 09:53:50 +10:00
md_5
404d6e776e SPIGOT-4036: Handle regular/uncoloured shulker boxes 2018-07-18 09:45:27 +10:00
md_5
322f2f9518 CraftBanner also needs to use wool data 2018-07-16 10:37:56 +10:00
Senmori
cfc30bb382 Add javadocs to new CraftBlockData utility methods. 2018-07-15 16:36:02 +10:00
md_5
421c1728c8 Update to Minecraft 1.13-pre7 2018-07-15 10:00:00 +10:00
md_5
f4ca1805d6 Fix bad usage of setter in previous commit 2018-02-12 10:38:09 +11:00
Senmori
f8411ea1e5 Expand Structure Block API 2018-02-12 10:33:19 +11:00
Senmori
c7656468e4 Expand CreatureSpawner API 2018-01-24 17:19:41 +11:00
md_5
67b763c5a7 Fix Block PistonMoveReaction 2018-01-10 10:47:26 +11:00
blablubbabc
45c83860e1 SPIGOT-3696: Clearing custom name of some blocks does not work 2017-12-17 11:41:56 +11:00
Lukas Hennig
e1f296d115 Fix CraftBanner initialisation. 2017-08-07 17:55:47 +10:00
Lukas Hennig
19507baf8b Improvements to BlockStates
* Actually capture all the data of TileEntities. This is done by creating a copy of the TileEntity. The methods of BlockState which currently directly access the TileEntity reference will modify the data of that TileEntity-snapshot instead.
* With the call to BlockState.update, the captured TileEntity data gets applied to the current TileEntity in the world.
* Methods which trigger block specific actions will use the current TileEntity from the world.
* CraftBlockState does not hand out the wrapped or the snapshot TileEntity directly. Instead, it provides an applyTo method to copy the data to a given TileEntity and a method to directly get a copy of the TileEntity NBT data represented by the BlockState. CraftMetaBlockState was updated to make use of that.
* Added #getSnapshotInventory() to bukkit which allows modifiying the captured inventory snapshots of containers.
* Tried to clarify which methods only work if the BlockState is placed, which methods require the block in the world to still be of the same type (methods which trigger actions), and that .getInventory() directly modifies the inventory of the block in the world if the BlockState is placed and becomes invalid if the block type is changed.

Backwards compatibility

* If the BlockState acts as InventoryHolder, getInventory() will still return the inventory directly backed by the TileEntity in the world (like before), and not the snapshot inventory. This compromise should reduce the potential of these changes to break existing plugins, or craftbukkit's own use of BlockState.
* The snapshot's inventory can be accessed by a new method getSnapshotInventory()
* In case the BlockState is not placed (if it was retrieved from the MetaBlockState of an item), the getInventory() method will however return the snapshot inventory. So that when the BlockState gets applied back to the item, the inventory changes are properly included.
* With the changes to CraftMetaBlockState it is no longer required to call the update method before passing a modified BlockState to the CraftMetaBlockState. For backwards compatibility the update method will simply return true for a non-placed BlockState, without actually doing anything.

Impact on plugins
* Restoring blocks now actually works as expected, properly restoring the TileEntity data, reglardless if the block changed its type in the meantime.
* Plugins are now consistently required to call the update method in order to apply changes to blocks. Though, regarding the Javadoc they should have been required to do so anyways.
* New feature: Plugins can take and modify inventory snapshots.
* Breaking change: If a plugin gets the BlockState of a block in the world, modifies the inventory returned by .getInventory(), and then tries to use the same BlockState to apply the TileEntity data to an ItemStack block meta, the ItemStack will use the snapshot inventory, disregarding the changes made to the inventory returned by .getInventory(). This is the compromise of .getInventory() returning the inventory directly backed by the TileEntity in the world.

Other fixes related to BlockState:
* TileEntityContainer#getLocation() will run into a NPE if the TileEntity is non-placed (ex. when getting the BlockState from a CraftMetaBlockState).
* Beacon.getEntitiesInRange() would previously throw a NPE if called for a non-placed BlockState. It was changed to now require to be placed and use the current TileEntity in the world. If the TileEntity in the world is no longer a beacon, it will return an empty list.
* EndGateway now supports setting and getting the exit location even for non-placed EndGateways (inside BlockStateMeta) by using / returning a location with world being null.
2017-08-05 14:37:19 +10:00
md_5
5195487ec6 Update to Minecraft 1.12-pre2 2017-05-14 12:00:00 +10:00
md_5
e17c3d285b Make CraftJukebox.isPlaying locally consistent 2017-04-16 08:26:51 +10:00
md_5
473febc73a Add correct interfaces for comparator / daylight detector 2017-04-16 08:16:49 +10:00
md_5
ac405c3cd4 Fix some blockstate consistency issues. 2017-04-15 18:01:44 +10:00
md_5
eac85911f0 Don't call super update on unplaced command block metas 2017-03-10 20:30:20 +11:00
md_5
217358e845 SPIGOT-2924: Improve handling of Jukeboxes playing nothing. 2016-12-17 09:45:14 +11:00
md_5
b6ad714e85 SPIGOT-2871: Improve BlockStates + BlockStateMeta 2016-12-02 09:29:33 +11:00
kaenganxt
2b7808f416 Fix banner color. Banners have inverted color bytes. 2016-11-25 21:02:13 +01:00
md_5
83fd16e453 SPIGOT-2835: CraftBlock getDrops Returns Air 2016-11-23 22:02:36 +11:00
Senmori
26377b763b Get Colors from ShulkerBox; Implement CustomName for Tiles. 2016-11-19 13:40:06 +11:00
md_5
f15e07b1a9 SPIGOT-2793: Revert Nameable changes 2016-11-19 03:10:04 +11:00
md_5
88eede85cc SPIGOT-2792: Return PIG for broken spawners 2016-11-18 15:32:27 +11:00
md_5
0805f60443 SPIGOT-2789: ShulkerBox missing override 2016-11-18 12:00:17 +11:00
Senmori
5e51afde49 Get Colors from ShulkerBox; Implement CustomName for Tiles. 2016-11-18 11:28:49 +11:00
md_5
c25ddf063a Update to Minecraft 1.11 2016-11-17 12:41:03 +11:00
Senmori
b6490dada5 SPIGOT-2706: Implement support for Lock NBT Tag
Containers may now implement the Lockable interface.
2016-10-21 16:35:55 +11:00
md_5
6af9f5b84a SPIGOT-2679: Add meta for StructureBlock 2016-09-18 09:58:54 +10:00
md_5
09f1a19609 Hook into World for light getters due to additional validation. 2016-07-25 19:04:06 +10:00
md_5
2a5461deb1 Enhance Beacon Block API 2016-07-23 10:55:43 +10:00
redwallhp
7655e38a47 Implement basic Beacon Block API 2016-07-23 10:49:05 +10:00
md_5
7ae605218b Fall back to name if skull has no uuid when getting player. 2016-07-22 12:02:16 +10:00
md_5
02d704b55a SPIGOT-2503: Optimize block set 2016-07-08 14:05:22 +10:00
md_5
00359a18fa SPIGOT-2456: Don't wipe tiles if type is still the same 2016-06-27 11:25:49 +10:00
md_5
0ebb9c7afa BUILDTOOLS-251: Make much of Bukkit locale independent 2016-06-26 19:32:05 +10:00
md_5
568e27fbd0 Fix air setting block updates 2016-06-26 12:31:24 +10:00
md_5
341da0730b SPIGOT-611: Improve setBlock for tile->tile transitions 2016-06-25 20:16:48 +10:00
md_5
a8a4bedd2a Update to Minecraft 1.10 2016-06-09 11:43:49 +10:00
md_5
0cd0397a82 SPIGOT-249: Set skull owner by UUID 2016-06-03 20:41:49 +10:00
md_5
a28041daa7 SPIGOT-1292: BlockState based FlowerPot API. 2016-06-03 20:41:43 +10:00
md_5
4e19de1295 SPIGOT-2285: New CommandBlock types. 2016-05-16 16:38:43 +10:00
md_5
88123f0569 SPIGOT-2286: Don't store CraftBlockState light level 2016-05-16 16:37:22 +10:00
md_5
c5e9a169fa Minecraft 1.9.4 2016-05-10 21:47:39 +10:00
md_5
5c23262f15 Update physics on attached block when setting data of attachable blocks 2016-04-09 12:57:19 +10:00
Matthew
e80114dff4 Implement EndGateway#isExactTeleport and EndGateway#setExactTeleport(boolean) 2016-03-18 14:30:03 +11:00
Matthew
205982588f Implement EndGateway#getExitLocation and EndGateway#setExitLocation(Location) 2016-03-18 14:30:03 +11:00
Matthew
da444904c2 Implement EndGateway state 2016-03-18 14:30:03 +11:00