From f4d977e794bc39db94711cd0b66addc92b8c3a3c Mon Sep 17 00:00:00 2001 From: md_5 Date: Sat, 21 Oct 2023 13:39:52 +1100 Subject: [PATCH] Simplify texture updating in CraftMetaSkull --- .../bukkit/craftbukkit/inventory/CraftMetaSkull.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaSkull.java b/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaSkull.java index 5852fcd9c..1c69d5672 100644 --- a/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaSkull.java +++ b/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaSkull.java @@ -11,7 +11,6 @@ import net.minecraft.SystemUtils; import net.minecraft.nbt.GameProfileSerializer; import net.minecraft.nbt.NBTTagCompound; import net.minecraft.resources.MinecraftKey; -import net.minecraft.world.level.block.entity.TileEntitySkull; import org.bukkit.Bukkit; import org.bukkit.Material; import org.bukkit.NamespacedKey; @@ -143,12 +142,13 @@ class CraftMetaSkull extends CraftMetaItem implements SkullMeta { // SPIGOT-6558: Set initial textures tag.put(SKULL_OWNER.NBT, serializedProfile); // Fill in textures - TileEntitySkull.fillProfileTextures(profile).thenAccept((optional) -> { - optional.ifPresent((filledProfile) -> { - setProfile(filledProfile); + PlayerProfile ownerProfile = getOwnerProfile(); + if (ownerProfile.getTextures().isEmpty()) { + ownerProfile.update().thenAccept((filledProfile) -> { + setOwnerProfile(filledProfile); tag.put(SKULL_OWNER.NBT, serializedProfile); }); - }); + } } if (noteBlockSound != null) {