From ee3d7258a5de8497c5d2e67aa631330d65a548ba Mon Sep 17 00:00:00 2001
From: blablubbabc <lukas@wirsindwir.de>
Date: Thu, 20 Jun 2024 07:04:11 +1000
Subject: [PATCH] SPIGOT-7789: Fix NPE in CraftMetaFirework applyToItem

---
 .../org/bukkit/craftbukkit/inventory/CraftMetaFirework.java | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaFirework.java b/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaFirework.java
index 91a481d8e..33c15a83d 100644
--- a/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaFirework.java
+++ b/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaFirework.java
@@ -185,8 +185,10 @@ class CraftMetaFirework extends CraftMetaItem implements FireworkMeta {
         }
 
         List<FireworkExplosion> effects = new ArrayList<>();
-        for (FireworkEffect effect : this.effects) {
-            effects.add(getExplosion(effect));
+        if (hasEffects()) {
+            for (FireworkEffect effect : this.effects) {
+                effects.add(getExplosion(effect));
+            }
         }
 
         itemTag.put(FIREWORKS, new Fireworks(power, effects));