From 9fde4c037cb8b8c2e44b5f06d2029f6e8180f79d Mon Sep 17 00:00:00 2001 From: Miles Holder Date: Sat, 6 Jan 2024 16:07:58 +1100 Subject: [PATCH] #1324: Improve ItemFactory#enchantItem consistency --- .../bukkit/craftbukkit/inventory/CraftItemFactory.java | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/main/java/org/bukkit/craftbukkit/inventory/CraftItemFactory.java b/src/main/java/org/bukkit/craftbukkit/inventory/CraftItemFactory.java index c1d9f917c..3c79efcf9 100644 --- a/src/main/java/org/bukkit/craftbukkit/inventory/CraftItemFactory.java +++ b/src/main/java/org/bukkit/craftbukkit/inventory/CraftItemFactory.java @@ -489,13 +489,8 @@ public final class CraftItemFactory implements ItemFactory { private static ItemStack enchantItem(RandomSource source, ItemStack itemStack, int level, boolean allowTreasures) { Preconditions.checkArgument(itemStack != null, "ItemStack must not be null"); Preconditions.checkArgument(!itemStack.getType().isAir(), "ItemStack must not be air"); - - if (!(itemStack instanceof CraftItemStack)) { - itemStack = CraftItemStack.asCraftCopy(itemStack); - } - + itemStack = CraftItemStack.asCraftCopy(itemStack); CraftItemStack craft = (CraftItemStack) itemStack; - EnchantmentManager.enchantItem(source, craft.handle, level, allowTreasures); - return craft; + return CraftItemStack.asCraftMirror(EnchantmentManager.enchantItem(source, craft.handle, level, allowTreasures)); } }