From 806bb02c177d08d9e2687897487f8e9b767a9ecf Mon Sep 17 00:00:00 2001 From: md_5 Date: Sat, 27 Nov 2021 16:42:28 +1100 Subject: [PATCH] SPIGOT-6810: Improve / fix biome setting code --- src/main/java/org/bukkit/craftbukkit/CraftWorld.java | 4 ++-- .../bukkit/craftbukkit/generator/CustomChunkGenerator.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/bukkit/craftbukkit/CraftWorld.java b/src/main/java/org/bukkit/craftbukkit/CraftWorld.java index 0aac7caef..b409580b6 100644 --- a/src/main/java/org/bukkit/craftbukkit/CraftWorld.java +++ b/src/main/java/org/bukkit/craftbukkit/CraftWorld.java @@ -734,7 +734,7 @@ public class CraftWorld extends CraftRegionAccessor implements World { @Override public void setBiome(int x, int z, Biome bio) { - for (int y = 0; y < getMaxHeight(); y++) { + for (int y = getMinHeight(); y < getMaxHeight(); y++) { setBiome(x, y, z, bio); } } @@ -746,7 +746,7 @@ public class CraftWorld extends CraftRegionAccessor implements World { net.minecraft.world.level.chunk.Chunk chunk = this.world.getChunkAt(pos); if (chunk != null) { - chunk.setBiome(x, y, z, bb); + chunk.setBiome(x >> 2, y >> 2, z >> 2, bb); chunk.setUnsaved(true); // SPIGOT-2890 } diff --git a/src/main/java/org/bukkit/craftbukkit/generator/CustomChunkGenerator.java b/src/main/java/org/bukkit/craftbukkit/generator/CustomChunkGenerator.java index 6a5d23106..d65f33a31 100644 --- a/src/main/java/org/bukkit/craftbukkit/generator/CustomChunkGenerator.java +++ b/src/main/java/org/bukkit/craftbukkit/generator/CustomChunkGenerator.java @@ -66,7 +66,7 @@ public class CustomChunkGenerator extends InternalChunkGenerator { @Override public void setBiome(int x, int z, Biome bio) { - for (int y = 0; y < world.getWorld().getMaxHeight(); y += 4) { + for (int y = world.getWorld().getMinHeight(); y < world.getWorld().getMaxHeight(); y += 4) { setBiome(x, y, z, bio); } }