Azimkin/CraftBukkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

#1238: Remove unnecessary sign ticking

Browse Source
This commit is contained in:
Miles Holder 2023-12-17 09:29:48 +11:00 committed by md_5
parent 659728d2a7
commit 1dbdbbed49
No known key found for this signature in database
GPG Key ID: E8E901AC7C617C11
4 changed files with 39 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
nms-patches/net/minecraft/world/level/block/BlockSign.patch
View File

@ -25,3 +25,11 @@
tileentitysign.setAllowedPlayerEditor(entityhuman.getUUID()); tileentitysign.setAllowedPlayerEditor(entityhuman.getUUID());
entityhuman.openTextEdit(tileentitysign, flag); entityhuman.openTextEdit(tileentitysign, flag);
} }
@@ -184,6 +193,6 @@
@Nullable
@Override
public <T extends TileEntity> BlockEntityTicker<T> getTicker(World world, IBlockData iblockdata, TileEntityTypes<T> tileentitytypes) {
- return createTickerHelper(tileentitytypes, TileEntityTypes.SIGN, TileEntitySign::tick);
+ return null; // Craftbukkit - remove unnecessary sign ticking
}
}

10
nms-patches/net/minecraft/world/level/block/CeilingHangingSignBlock.patch Normal file
View File

@ -0,0 +1,10 @@
--- a/net/minecraft/world/level/block/CeilingHangingSignBlock.java
+++ b/net/minecraft/world/level/block/CeilingHangingSignBlock.java
@@ -161,6 +161,6 @@
@Nullable
@Override
public <T extends TileEntity> BlockEntityTicker<T> getTicker(World world, IBlockData iblockdata, TileEntityTypes<T> tileentitytypes) {
- return createTickerHelper(tileentitytypes, TileEntityTypes.HANGING_SIGN, TileEntitySign::tick);
+ return null; // Craftbukkit - remove unnecessary sign ticking
}
}

10
nms-patches/net/minecraft/world/level/block/WallHangingSignBlock.patch Normal file
View File

@ -0,0 +1,10 @@
--- a/net/minecraft/world/level/block/WallHangingSignBlock.java
+++ b/net/minecraft/world/level/block/WallHangingSignBlock.java
@@ -186,6 +186,6 @@
@Nullable
@Override
public <T extends TileEntity> BlockEntityTicker<T> getTicker(World world, IBlockData iblockdata, TileEntityTypes<T> tileentitytypes) {
- return createTickerHelper(tileentitytypes, TileEntityTypes.HANGING_SIGN, TileEntitySign::tick);
+ return null; // Craftbukkit - remove unnecessary sign ticking
}
}

12
nms-patches/net/minecraft/world/level/block/entity/TileEntitySign.patch
View File

@ -132,7 +132,17 @@
} }
@Override @Override
@@ -281,7 +342,7 @@ @@ -276,12 +337,17 @@
@Nullable
public UUID getPlayerWhoMayEdit() {
+ // CraftBukkit start - unnecessary sign ticking removed, so do this lazily
+ if (this.level != null && this.playerWhoMayEdit != null) {
+ clearInvalidPlayerWhoMayEdit(this, this.level, this.playerWhoMayEdit);
+ }
+ // CraftBukkit end
return this.playerWhoMayEdit;
}
private void markUpdated() { private void markUpdated() {
this.setChanged(); this.setChanged();