Azimkin/Bukkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Bleeding] Fixed file handle leak in /timings command. Addresses BUKKIT-853

Browse Source
This commit is contained in:
Score_Under 2012-02-25 17:39:54 +00:00 committed by EvilSeph
parent 3440a1f2ee
commit eb3c161180
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/main/java/org/bukkit/command/defaults/TimingsCommand.java
View File

@ -53,9 +53,10 @@ public class TimingsCommand extends Command {
File timings = new File(timingFolder, "timings.txt");
File names = null;
while (timings.exists()) timings = new File(timingFolder, "timings" + (++index) + ".txt");
try {
PrintStream fileTimings = new PrintStream(timings);
PrintStream fileTimings = null;
PrintStream fileNames = null;
try {
fileTimings = new PrintStream(timings);
if (separate) {
names = new File(timingFolder, "names" + index + ".txt");
fileNames = new PrintStream(names);
@ -87,6 +88,13 @@ public class TimingsCommand extends Command {
sender.sendMessage("Timings written to " + timings.getPath());
if (separate) sender.sendMessage("Names written to " + names.getPath());
} catch (IOException e) {
} finally {
if (fileTimings != null) {
fileTimings.close();
}
if (fileNames != null) {
fileNames.close();
}
}
}
return true;