Clarify some of the verbose in SimplePluginManager.

When an exception occurs, the version of the plugin is not included.
Having this information would be beneficial to plugin authors performing
debug.

The list of authors for NagAuthorException verbose (although unused)
would be more appropriate to simply include all authors, as opposed to
the first appearing.
This commit is contained in:
Wesley Wolfe 2012-09-30 03:35:06 -05:00
parent b23edfd2d3
commit 955e0c437c

View File

@ -481,20 +481,15 @@ public final class SimplePluginManager implements PluginManager {
if (plugin.isNaggable()) { if (plugin.isNaggable()) {
plugin.setNaggable(false); plugin.setNaggable(false);
String author = "<NoAuthorGiven>";
if (plugin.getDescription().getAuthors().size() > 0) {
author = plugin.getDescription().getAuthors().get(0);
}
server.getLogger().log(Level.SEVERE, String.format( server.getLogger().log(Level.SEVERE, String.format(
"Nag author: '%s' of '%s' about the following: %s", "Nag author(s): '%s' of '%s' about the following: %s",
author, plugin.getDescription().getAuthors(),
plugin.getDescription().getName(), plugin.getDescription().getFullName(),
ex.getMessage() ex.getMessage()
)); ));
} }
} catch (Throwable ex) { } catch (Throwable ex) {
server.getLogger().log(Level.SEVERE, "Could not pass event " + event.getEventName() + " to " + registration.getPlugin().getDescription().getName(), ex); server.getLogger().log(Level.SEVERE, "Could not pass event " + event.getEventName() + " to " + registration.getPlugin().getDescription().getFullName(), ex);
} }
} }
} }