Azimkin/Bukkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

... Supporting the plugins which really shouldn't be doing what they're doing. Don't put crap in the constructor!

Browse Source
This commit is contained in:
Dinnerbone 2011-02-20 00:43:06 +00:00
parent 1a2c154145
commit 346de2a934
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/main/java/org/bukkit/plugin/java/JavaPlugin.java
View File

@ -38,6 +38,8 @@ public abstract class JavaPlugin implements Plugin {
public JavaPlugin(PluginLoader pluginLoader, Server instance, public JavaPlugin(PluginLoader pluginLoader, Server instance,
PluginDescriptionFile desc, File folder, File plugin, PluginDescriptionFile desc, File folder, File plugin,
ClassLoader cLoader) { ClassLoader cLoader) {
initialize(pluginLoader, instance, desc, folder, plugin, cLoader);
System.out.println("Using the stupidly long constructor " + desc.getMain() + "(PluginLoader, Server, PluginDescriptionFile, File, File, ClassLoader) is no longer recommended. Go nag the plugin author of " + desc.getName() + " to remove it! (Nothing is broken, we just like to keep code clean.)"); System.out.println("Using the stupidly long constructor " + desc.getMain() + "(PluginLoader, Server, PluginDescriptionFile, File, File, ClassLoader) is no longer recommended. Go nag the plugin author of " + desc.getName() + " to remove it! (Nothing is broken, we just like to keep code clean.)");
ArrayList<String> authors = desc.getAuthors(); ArrayList<String> authors = desc.getAuthors();
@ -161,22 +163,20 @@ public abstract class JavaPlugin implements Plugin {
* @param file File containing this plugin * @param file File containing this plugin
* @param classLoader ClassLoader which holds this plugin * @param classLoader ClassLoader which holds this plugin
*/ */
protected void initialize(PluginLoader loader, Server server, protected final void initialize(PluginLoader loader, Server server,
PluginDescriptionFile description, File dataFolder, File file, PluginDescriptionFile description, File dataFolder, File file,
ClassLoader classLoader) { ClassLoader classLoader) {
if (initialized) { if (!initialized) {
throw new UnsupportedOperationException("Cannot reinitialize a plugin"); this.initialized = true;
this.loader = loader;
this.server = server;
this.file = file;
this.description = description;
this.dataFolder = dataFolder;
this.classLoader = classLoader;
this.config = new Configuration(new File(dataFolder, "config.yml"));
this.config.load();
} }
this.initialized = true;
this.loader = loader;
this.server = server;
this.file = file;
this.description = description;
this.dataFolder = dataFolder;
this.classLoader = classLoader;
this.config = new Configuration(new File(dataFolder, "config.yml"));
this.config.load();
} }
/** /**