Azimkin/Bukkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Bleeding] Added missing NPE protection to removeMetadata(). Fixes BUKKIT-933

Browse Source
This commit is contained in:
rmichela 2012-03-05 22:33:22 -05:00 committed by EvilSeph
parent 561f736645
commit 2658dd873f
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/main/java/org/bukkit/metadata/MetadataStoreBase.java
View File

@ -82,6 +82,7 @@ public abstract class MetadataStoreBase<T> {
public synchronized void removeMetadata(T subject, String metadataKey, Plugin owningPlugin) { public synchronized void removeMetadata(T subject, String metadataKey, Plugin owningPlugin) {
String key = cachedDisambiguate(subject, metadataKey); String key = cachedDisambiguate(subject, metadataKey);
List<MetadataValue> metadataList = metadataMap.get(key); List<MetadataValue> metadataList = metadataMap.get(key);
if (metadataList == null) return;
for (int i = 0; i < metadataList.size(); i++) { for (int i = 0; i < metadataList.size(); i++) {
if (metadataList.get(i).getOwningPlugin().equals(owningPlugin)) { if (metadataList.get(i).getOwningPlugin().equals(owningPlugin)) {
metadataList.remove(i); metadataList.remove(i);